Skip to content

Conversation

@glasnt
Copy link
Contributor

@glasnt glasnt commented Jan 29, 2025

Description

Resolves issues in updates to the testing stack.

  • Ensure host authorization for all hosts while in development (solves for "Host not permitted")
  • Use no-sandbox flag to ensure successful execution in Docker (prevents timeouts)
  • Use NET::HTTP for external URL validation (prevents visit's host limitation)

Internal b/392885740

Would appreciate review and confirmation before applying to other samples in appengine/ space

Checklist

  • Tests pass
  • Lint pass: bundle exec rubocop
  • Please merge this PR for me once it is approved.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 29, 2025
@glasnt glasnt changed the title debug: attempt to refactor capybara testing debug(appengine/standard-storage): attempt to refactor capybara testing Jan 29, 2025
@glasnt glasnt changed the title debug(appengine/standard-storage): attempt to refactor capybara testing fix(appengine/standard-storage): refactor capybara testing Jan 29, 2025
@glasnt glasnt marked this pull request as ready for review January 29, 2025 14:34
@glasnt glasnt requested review from a team as code owners January 29, 2025 14:34
@snippet-bot
Copy link

snippet-bot bot commented Jan 29, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

configure :development do
set :host_authorization, { permitted_hosts: [] }
end
# [START gae_standard_storage_app]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: move this re-START tag down one line so we don't end up with two blank lines in the published sample.

@product-auto-label product-auto-label bot added the api: appengine Issues related to the App Engine Admin API API. label Jan 30, 2025
@glasnt glasnt merged commit 757ce64 into main Jan 31, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants