Skip to content

chore: Add missing gem for running test#1691

Merged
iennae merged 1 commit intoGoogleCloudPlatform:mainfrom
amcolin:add-benchmark-gem
Apr 7, 2026
Merged

chore: Add missing gem for running test#1691
iennae merged 1 commit intoGoogleCloudPlatform:mainfrom
amcolin:add-benchmark-gem

Conversation

@amcolin
Copy link
Copy Markdown
Contributor

@amcolin amcolin commented Apr 1, 2026

Description

This PR addresses compatibility issues introduced by the upgrade to Ruby 4. The changes focus on resolving dependency resolution failures, native gem compilation errors, and updated linting requirements.

Fixes Internal b/498718828

Checklist

  • Tests pass
  • Lint pass: bundle exec rubocop
  • Please merge this PR for me once it is approved.

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Apr 1, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Gemfile to include the rubocop and benchmark gems within the development and test group. A review comment suggests using double quotes for these new entries to maintain stylistic consistency with the existing gem declarations in the file.

Comment thread Gemfile Outdated
@amcolin amcolin force-pushed the add-benchmark-gem branch 5 times, most recently from 3940e5d to eb25664 Compare April 2, 2026 03:58
@amcolin amcolin force-pushed the add-benchmark-gem branch from eb25664 to b87972a Compare April 6, 2026 17:08
@amcolin amcolin marked this pull request as ready for review April 6, 2026 17:20
@amcolin amcolin requested review from a team as code owners April 6, 2026 17:20
@iennae iennae merged commit 69ce74b into GoogleCloudPlatform:main Apr 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants