Updates to fix the Endpoints sample.#42
Merged
beccasaurus merged 6 commits intomasterfrom Aug 31, 2016
Merged
Conversation
Updates gem versions. Updates the README to mention usage of Ruby 2.0.0+ and to fix the deploy command. Fixes the echo client as to_json method doesn't exist. Fixes the google id token client as 'open' not a command in Linux.
| @@ -0,0 +1 @@ | |||
| endpoints/ | |||
Contributor
There was a problem hiding this comment.
Does an endpoints/ subdirectory get used or generated by this sample? Just wondering why to ignore this subdirectory
Contributor
Author
There was a problem hiding this comment.
Yes. When doing "glcoud beta app deploy", endpoints/service.json gets created.
This reverts commit f039bce.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates gem versions.
Updates the README to mention usage of Ruby 2.0.0+ and to fix the deploy
command.
Fixes the echo client as to_json method doesn't exist.
Fixes the google id token client as 'open' not a command in Linux.