Support hub IDs in versioned server config#92
Merged
ptone merged 1 commit intoGoogleCloudPlatform:mainfrom Apr 11, 2026
Merged
Conversation
mfreeman451
force-pushed
the
fix/versioned-server-hub-id
branch
from
9ff2ca1 to
8280c53
Compare
scion-gteam bot
pushed a commit
to ptone/scion
that referenced
this pull request
Apr 12, 2026
The V1 settings layer was missing the hub_id field, so deployments using versioned settings.yaml could not pin a stable Hub ID through that path. Add hub_id to V1ServerHubConfig and preserve it across V1 <-> GlobalConfig conversions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hub_idtoV1ServerHubConfigGlobalConfigProblem
Versioned
settings.yamlcurrently dropsserver.hub.hub_id, so deployments that rely on versioned server config cannot pin a stable Hub ID through that path.Validation
go test ./pkg/config -run 'TestConvertV1ServerToGlobalConfig_Basic|TestConvertGlobalToV1ServerConfig_RoundTrip|TestLoadGlobalConfig_FromSettingsYAML'Refs #91