Handle failures to process stacktraces.#17
Merged
steren merged 1 commit intoGoogleCloudPlatform:masterfrom Aug 4, 2017
Merged
Conversation
This can manifest as "Unhandled promise rejection" or "Cannot parse given Error object" messages in the browser, that occur *while* trying to run the stackdriver-errors-js code...though you'd never know it unless you were also running another javascript-error-reporting system (like I was) These breaking exceptions can happen with stacktraces like "Access Denied", which stacktrace.js fails on: stacktracejs/stacktrace.js#170
Collaborator
|
Great addition, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can manifest as "Unhandled promise rejection" or "Cannot parse given Error object" messages in the browser, that occur while trying to run the stackdriver-errors-js code...though you'd never know it unless you were also running another javascript-error-reporting system (like I was)
These breaking exceptions can happen with stacktraces like "Access Denied", which stacktrace.js fails on:
stacktracejs/stacktrace.js#170