Hotfix 26 stack trace missing#30
Merged
steren merged 8 commits intoGoogleCloudPlatform:masterfrom Dec 12, 2017
Jastrzebowski:hotfix-26-StackTrace-missing
Merged
Hotfix 26 stack trace missing#30steren merged 8 commits intoGoogleCloudPlatform:masterfrom Jastrzebowski:hotfix-26-StackTrace-missing
steren merged 8 commits intoGoogleCloudPlatform:masterfrom
Jastrzebowski:hotfix-26-StackTrace-missing
Conversation
Contributor
Jastrzebowski
commented
Dec 11, 2017
Jastrzebowski
commented
- Add an error on init if StackTrace is missing
- Add tests
- Fix minor code style issues
* Add an error on init if StackTrace is missing * Add tests * Fix minor style issues inconsistence in quotes
steren
reviewed
Dec 11, 2017
Collaborator
steren
left a comment
steren
left a comment
There was a problem hiding this comment.
Can you separate the refactoring changes (" -> ')
| * limitations under the License. | ||
| */ | ||
| (function(exports) { | ||
| "use strict"; |
Collaborator
There was a problem hiding this comment.
Can you separate these quotes refactoring from the actual change (in 2 different PRs)
| } | ||
| if(typeof StackTrace === 'undefined') { | ||
| // Inform about missing dependency | ||
| throw new Error('Cannot initialize: StackTrace object is missing, check if concat.dist.js version of stackdriver-errors was loaded'); |
Collaborator
There was a problem hiding this comment.
can you use "make sure you loaded "dist/stackdriver-errors-concat.js" or "dist/stackdriver-errors-concat.min.js", or that you imported the "stacktrace-js" module"
Collaborator
|
Thanks! |
…stackdriver-errors-js into hotfix-26-StackTrace-missing
steren
reviewed
Dec 12, 2017
| expect(function() {errorHandler.start({projectId:'projectId', key:'key'});}).to.throw(Error, /StackTrace/); | ||
| window.StackTrace = stackTrace | ||
| }); | ||
| <<<<<<< HEAD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.