docs: Add comment to clarify url-encoding of object names#248
Merged
camiekim merged 2 commits intoGoogleCloudPlatform:mainfrom Oct 23, 2024
Merged
docs: Add comment to clarify url-encoding of object names#248camiekim merged 2 commits intoGoogleCloudPlatform:mainfrom
camiekim merged 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
Per b/371471777
product-auto-label
Bot
added
api: workflows
Per b/371471777
pikapower
approved these changes
Oct 23, 2024
Contributor
rspruyt-google
left a comment
rspruyt-google
left a comment
There was a problem hiding this comment.
We could go this route, although my suggestion would be
-object_name: ${text.url_encode("FILE_NAME.txt")}
the encoding is a no-op in this case, but safe for uses of both "FILE_NAME.txt" and "XX/FILE_NAME.txt" to be more direct about it for anyone copying and pasting. Here and the other file. Your call.
Contributor
Author
|
Sure, sounds good, will open a PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per b/371471777