test: fix TestStressMemoryUsageHelm timeout #1867
Conversation
This updates the WatchForAllSyncs calls in the helm stress test to use the default timeout instead of a hard coded timeout. The default timeout is set programmatically, and is longer for autopilot (10 minutes instead of the hard coded 5 minutes). This is intended to fix timeout errors with this test on autopilot.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @sdowell, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses test flakiness by modifying timeout settings within a specific stress test. The change ensures that the test leverages dynamically configured timeouts rather than a fixed duration, which is crucial for stability across varying execution environments, especially those with longer default timeout requirements.
Highlights
- Timeout Configuration Update: The
WatchForAllSyncscalls in theTestStressMemoryUsageHelmtest have been updated to remove the hardcoded 5-minute timeout. They now utilize the default programmatic timeout. - Addressing Autopilot Test Failures: This change is specifically intended to resolve timeout errors encountered by the
TestStressMemoryUsageHelmtest, particularly when running in autopilot environments where the default timeout is longer (10 minutes).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request addresses a timeout issue in TestStressMemoryUsageHelm by removing the hardcoded 5-minute timeout and relying on the default timeout for WatchForAllSyncs. According to the description, this default is longer on autopilot clusters, which should resolve the test flakiness. The change is simple, correct, and consistent with other stress tests in the suite. I have no further comments.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiffanny29631 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 0ceac06
into
GoogleContainerTools:main
This updates the WatchForAllSyncs calls in the helm stress test to use the default timeout instead of a hard coded timeout. The default timeout is set programmatically, and is longer for autopilot (10 minutes instead of the hard coded 5 minutes). This is intended to fix timeout errors with this test on autopilot.
This updates the WatchForAllSyncs calls in the helm stress test to use the default timeout instead of a hard coded timeout. The default timeout is set programmatically, and is longer for autopilot (10 minutes instead of the hard coded 5 minutes). This is intended to fix timeout errors with this test on autopilot.
2 participants
This updates the WatchForAllSyncs calls in the helm stress test to use the default timeout instead of a hard coded timeout. The default timeout is set programmatically, and is longer for autopilot (10 minutes instead of the hard coded 5 minutes).
This is intended to fix timeout errors with this test on autopilot.