test: Skip ResourceGroup checks for deselected CRDs#1931
test: Skip ResourceGroup checks for deselected CRDs#1931google-oss-prow[bot] merged 1 commit intoGoogleContainerTools:mainfrom
Conversation
The TestClusterSelectorForCRD test occasionally fails because WatchForAllSyncs incorrectly expects a Current status for CRDs that were deselected via cluster name selectors and thus marked for deletion. This change modifies the WatchForAllSyncs calls in TestClusterSelectorForCRD to include nomostest.SkipAllResourceGroupChecks()
Summary of ChangesHello @Camila-B, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an intermittent test failure within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a flaky test, TestClusterSelectorForCRD, by skipping the ResourceGroup status check for deselected CRDs. The change correctly uses nomostest.SkipAllResourceGroupChecks() in the WatchForAllSyncs calls to avoid a race condition where the test would fail while waiting for a Current status on a CRD that is being deleted. The subsequent WatchForNotFound call correctly ensures that the deselected CRD is eventually removed. The fix is well-targeted and effectively resolves the described test flakiness.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiffanny29631 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 17f88d2
into
GoogleContainerTools:main
…ools#1931) The TestClusterSelectorForCRD test occasionally fails because WatchForAllSyncs incorrectly expects a Current status for CRDs that were deselected via cluster name selectors and thus marked for deletion. This change modifies the WatchForAllSyncs calls in TestClusterSelectorForCRD to include nomostest.SkipAllResourceGroupChecks()
The TestClusterSelectorForCRD test occasionally fails because WatchForAllSyncs incorrectly expects a Current status for CRDs that were deselected via cluster name selectors and thus marked for deletion. This change modifies the WatchForAllSyncs calls in TestClusterSelectorForCRD to include nomostest.SkipAllResourceGroupChecks()
2 participants
The TestClusterSelectorForCRD test occasionally fails because WatchForAllSyncs incorrectly expects a Current status for CRDs that were deselected via cluster name selectors and thus marked for deletion.
This change modifies the WatchForAllSyncs calls in TestClusterSelectorForCRD to include nomostest.SkipAllResourceGroupChecks().
Example test failure: https://oss.gprow.dev/view/gcs/oss-prow-build-kpt-config-sync/logs/kpt-config-sync-autopilot-rapid-latest/1987275225326161920