refactor: Consolidate Makefile tool installation and cleanup targets

[Camila-B]

• Uses new go_install and script_install macros for tool installation and cleanup targets

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the project's Makefile by introducing generic macros for installing and cleaning up development tools. This change centralizes the logic for managing external dependencies, making the Makefile more maintainable, consistent, and easier to extend with new tools in the future. The impact is a cleaner and more organized build system.

Highlights

• Consolidated Tool Installation: Introduced go_install and script_install macros in the main Makefile to standardize the installation process for various development tools.
• Streamlined Cleanup Targets: Integrated cleanup logic directly into the new macros, automatically generating clean-<tool-name> targets for installed tools.
• Reduced Redundancy: Replaced numerous repetitive tool-specific installation and cleanup targets with concise macro calls, significantly reducing boilerplate code.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• Makefile
  • Added go_install macro for Go-based tool installation and cleanup.
  • Added script_install macro for script-based tool installation and cleanup.
  • Replaced individual go-licenses, addlicense, golangci-lint, cosign, kind, go-junit-report, crane, kustomize, and helm installation and cleanup targets with calls to the new macros.
  • Added controller-gen to the list of tools managed by the go_install macro.
• Makefile.reconcilermanager
  • Removed redundant controller-gen installation and cleanup targets, as these are now handled by the main Makefile's new macros.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces go_install and script_install macros to simplify tool installation and cleanup targets in the Makefile, significantly reducing code duplication. The refactoring is a good improvement for maintainability. However, I've found a regression in the go_install macro where it no longer sets CGO_ENABLED=0 for certain tools, which was part of the original build process. I've left comments with suggestions on how to address this by adding support for optional environment variables to the macro.

[tiffanny29631]

Check dir before removes to prevent rm the root

[tiffanny29631]

/lgtm

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiffanny29631

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [tiffanny29631]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment