chore: bump Golang to 1.25.10#2155
chore: bump Golang to 1.25.10#2155google-oss-prow[bot] merged 1 commit intoGoogleContainerTools:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Go version from 1.25.9 to 1.25.10 in the Makefile and go.mod. Feedback was provided regarding the need to synchronize the go.sum file and vendor directory, and to run formatting tools to maintain consistency with the project's style guide.
| module github.com/GoogleContainerTools/config-sync | ||
|
|
||
| go 1.25.9 | ||
| go 1.25.10 |
There was a problem hiding this comment.
When updating the Go version in go.mod, it is important to also update the go.sum file and the vendor/ directory (specifically vendor/modules.txt) to maintain consistency, as per the Repository Style Guide (lines 102, 104). Additionally, it is recommended to run make fmt-go as a new Go version may introduce minor formatting changes. Please run make deps and make fmt-go, and include the resulting changes in this pull request to ensure CI passes.
References
- Dependencies are managed with Go Modules (go.mod and go.sum) and vendored in the vendor directory. These should be kept in sync. (link)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiffanny29631 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
Bot
merged commit b9acdf0
into
GoogleContainerTools:main
2 participants
Fixes CVEs