Nomos CLI: replace APIGROUP with APIVERSION#868
Merged
google-oss-prow[bot] merged 3 commits intoSep 26, 2023
Conversation
janetkuo
reviewed
Sep 12, 2023
victorpras
force-pushed
the
apigroup
branch
from
b855d10 to
b4cd74f
Compare
janetkuo
reviewed
Sep 18, 2023
victorpras
force-pushed
the
apigroup
branch
from
1c0aaf4 to
f60727e
Compare
janetkuo
reviewed
Sep 21, 2023
victorpras
force-pushed
the
apigroup
branch
from
6493630 to
d19bbeb
Compare
nan-yu
reviewed
Sep 26, 2023
Contributor
|
only one minor nit, otherwise looks good. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nan-yu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
victorpras
added a commit
to victorpras/kpt-config-sync
that referenced
this pull request
Sep 26, 2023
* Nomos CLI: replace APIGROUP with APIVERSION * NIT CR feedback * CR feedback
victorpras
added a commit
to victorpras/kpt-config-sync
that referenced
this pull request
Sep 26, 2023
* Nomos CLI: replace APIGROUP with APIVERSION * NIT CR feedback * CR feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APIGROUPcolumn name has been replaced from Kubernetes v1.20 onwards withAPIVERSION. This has broken the usage ofapi-resources.txtwith Nomos command for users using Kubernetes v1.20 or newer.b/299337751