Add vsdbg for .net core#23
Merged
quoctruong merged 2 commits intoGoogleContainerTools:duct-tapefrom May 8, 2019
Merged
Conversation
briandealwis
reviewed
May 8, 2019
| COPY --from=delve /go/bin/dlv go/bin/ | ||
| COPY --from=python27 /ptvsd/ python/ | ||
| COPY --from=python37 /ptvsd/ python/ | ||
| COPY --from=netcore /vsdbg/ netcore/ |
Member
There was a problem hiding this comment.
Will vsdbg support future versions like .NET 5? Should we version this directory?
Contributor
Author
There was a problem hiding this comment.
vsdbg seems to work with all versions of .NET Core so far (1.0, 2.0 and soon to be released 3.0) so I don't think that will be a problem.
Contributor
Author
There was a problem hiding this comment.
That being said, I just realized vsdbg is runtime specific so this version of vsdbg will only work for Linux container.
Member
There was a problem hiding this comment.
That's true of the python support files too. We'll have to publish separate images when/if we support alternative os/arch combinations.
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL @briandealwis