Conversation
chanseokoh
approved these changes
Aug 6, 2018
| return resolve(System.getProperties()); | ||
| } | ||
|
|
||
| static OperatingSystem resolve(Properties properties) { |
Contributor
Author
There was a problem hiding this comment.
This is actually used by UserCacheHome (for testability). The other resolve will be useful for other classes that do not need fake out the Properties.
| WINDOWS; | ||
|
|
||
| /** | ||
| * Resolves the operating system type. * |
| @Test | ||
| public void testMacOs() { | ||
| Properties fakeProperties = new Properties(); | ||
| fakeProperties.setProperty("os.name", "os is mAc or DaRwIn"); |
Member
There was a problem hiding this comment.
It'd be better to split this into two cases: mAc and DaRwIn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for resolving which binary of
skaffoldto download.