Simplify updating Go/Delve image#40
Merged
briandealwis merged 1 commit intoGoogleContainerTools:duct-tapefrom Jun 3, 2020
Merged
Simplify updating Go/Delve image#40briandealwis merged 1 commit intoGoogleContainerTools:duct-tapefrom
briandealwis merged 1 commit intoGoogleContainerTools:duct-tapefrom
Conversation
loosebazooka
reviewed
Jun 1, 2020
quoctruong
approved these changes
Jun 1, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the Go image for a new version of Delve (like in #39) is harder than it should be as the Delve version is featured in several places in the Dockerfile and in the Delve patch introduced in #38.
This patch renamed the Delve extraction point to remove the version string, and removes the version from the patch. It also adds some additional context for the patch.