Bumping non-snapshot packages to latest stable versions#2067
Conversation
Signed-off-by: Distroless Bot <distroless-bot@google.com>
|
🌳 🔧 Config Check This pull request has not modified the root BUILD |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Java Temurin versions (17 and 21) and Debian package metadata across lock files and test configurations. The review feedback correctly identifies that the version bumps are inconsistent across architectures. Specifically, while the test expectations were updated to Java 21.0.11, several architectures in the lock files remain pinned to 21.0.10, which will lead to test failures on those platforms.
| "https://packages.adoptium.net/artifactory/deb/pool/main/t/temurin-21/temurin-21-jre_21.0.11.0.0+10-0_amd64.deb" | ||
| ], | ||
| "version": "21.0.10.0.0+7-1" | ||
| "version": "21.0.11.0.0+10-0" |
There was a problem hiding this comment.
The Java 21 version bump to 21.0.11.0.0+10-0 is only applied to the amd64 architecture, while other architectures (e.g., arm64 at line 100, s390x at line 166) remain on 21.0.10.0.0+7-0. Similarly, Java 17 was bumped for ppc64el but remains on 17.0.18 for others. This inconsistency across architectures can lead to unexpected behavior and test failures in multi-arch environments, especially since the test expectations in java/testdata/java21_debian13.yaml have been updated to 21.0.11.
| command: "/usr/lib/jvm/temurin-21-jre-amd64/bin/java" | ||
| args: ["-version"] | ||
| expectedError: ['openjdk version "21.0.10"'] | ||
| expectedError: ['openjdk version "21.0.11"'] |
There was a problem hiding this comment.
Updating the expected version to 21.0.11 will cause test failures on architectures other than amd64 (such as arm64, s390x, and riscv64) because those architectures are still pinned to version 21.0.10 in private/repos/deb/trixie_adoptium.lock.json.
| command: "/usr/lib/jvm/temurin-21-jdk-amd64/bin/java" | ||
| args: ["-version"] | ||
| expectedError: ['openjdk version "21.0.10"'] | ||
| expectedError: ['openjdk version "21.0.11"'] |
There was a problem hiding this comment.
Updating the expected version to 21.0.11 will cause test failures on architectures other than amd64 (such as arm64, s390x, and riscv64) because those architectures are still pinned to version 21.0.10 in private/repos/deb/trixie_adoptium.lock.json.
|
🌳 🔄 Image Check This pull request has modified the following images: //java:java17_root_ppc64le_debian13
//java:java17_debug_nonroot_ppc64le_debian13
//java:java17_debug_root_ppc64le_debian13
//java:java17_root_ppc64le_debian13
//java:java21_nonroot_amd64_debian13
//java:java21_root_amd64_debian13
//java:java21_debug_nonroot_amd64_debian13
//java:java21_debug_root_amd64_debian13
//java:java17_debug_nonroot_ppc64le_debian13
//java:java21_debug_nonroot_amd64_debian13
//java:java21_nonroot_amd64_debian13
//java:java21_root_amd64_debian13
//java:java17_nonroot_ppc64le_debian13
//java:java17_nonroot_ppc64le_debian13
//java:java21_debug_root_amd64_debian13
//java:java17_debug_root_ppc64le_debian13You can check the details in the report here |
2 participants
Bumping non-snapshot packages to latest stable version