Skip to content

Comments

Replace deprecated command with environment file#155

Merged
lqiu96 merged 1 commit intoGoogleContainerTools:masterfrom
jongwooo:chore/replace-deprecated-command-with-environment-file
May 1, 2023
Merged

Replace deprecated command with environment file#155
lqiu96 merged 1 commit intoGoogleContainerTools:masterfrom
jongwooo:chore/replace-deprecated-command-with-environment-file

Conversation

@jongwooo
Copy link
Contributor

@jongwooo jongwooo commented Apr 27, 2023

Thank you for your interest in contributing! For general guidelines, please refer to
the contributing guide.

Before submitting a pull request, please make sure to:

  • Identify an existing issue to associate
    with your proposed change, or file a new issue.
  • Describe any implementation plans in the issue and wait for a review from the repository maintainers.

Fixes #154 🛠️

Update .github/workflows/sonar.yml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

run: echo "::set-output name=date::$(date +'%Y-%m-%d' --utc)"

TO-BE

run: echo "date=$(date +'%Y-%m-%d' --utc)" >> $GITHUB_OUTPUT

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lqiu96
Copy link
Contributor

lqiu96 commented May 1, 2023

Thanks!

@lqiu96 lqiu96 merged commit 61c2ba7 into GoogleContainerTools:master May 1, 2023
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch May 2, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file

2 participants