This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Add a mode to save to a tarball instead of pushing.#178
Merged
dlorenc merged 1 commit intoGoogleContainerTools:masterfrom May 15, 2018
dlorenc:tar
Merged
Add a mode to save to a tarball instead of pushing.#178dlorenc merged 1 commit intoGoogleContainerTools:masterfrom dlorenc:tar
dlorenc merged 1 commit intoGoogleContainerTools:masterfrom
dlorenc:tar
Conversation
nkubala
reviewed
May 14, 2018
pkg/executor/executor.go
Outdated
| } | ||
|
|
||
| if opts.TarPath != "" { | ||
| return tarball.Write(opts.TarPath, destRef, sourceImage, nil) |
Contributor
There was a problem hiding this comment.
This was changed to WriteToFile in a more recent commit, could you update the dependencies and this line?
Contributor
Author
There was a problem hiding this comment.
Good catch. Just merged in another PR that updated the dep, and redid this.
nkubala
approved these changes
May 14, 2018
Contributor
nkubala
left a comment
nkubala
left a comment
There was a problem hiding this comment.
LGTM. The test that's failing is a bug in container-structure-test that will be fixed by GoogleContainerTools/container-structure-test#137
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #144