chore: Upgrade golang version to 1.26.2#10043
chore: Upgrade golang version to 1.26.2#10043alphanota merged 6 commits intoGoogleContainerTools:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Go version from 1.25.7 to 1.26.2 in both the Dockerfile dependencies and the go.mod file. A critical issue was identified where the go.sum and vendor/ directory were not updated to reflect this change, which will lead to build failures in CI due to the project's reliance on vendored modules.
| module github.com/GoogleContainerTools/skaffold/v2 | ||
|
|
||
| go 1.25.8 | ||
| go 1.26.2 |
There was a problem hiding this comment.
The Go version has been updated to 1.26.2, but the pull request does not include the corresponding updates to the go.sum file and the vendor/ directory (specifically vendor/modules.txt). Since the project's Makefile (lines 80 and 101) uses the -mod=vendor flag for builds, the build will fail in CI environments that enforce vendor consistency because the Go version in go.mod will not match the one recorded in vendor/modules.txt. Please run go mod tidy and go mod vendor and include the resulting changes in this pull request.
3 participants
Upgrade golang version is skaffold repo to 1.26.2