fix: correctly set the default value of StatusCheck to nil

[sberss]

Description

The statusCheck option in the deploy config section was not working as expected. The value from the skaffold config was never picked up, however it was doing the right thing when --status-check was used on the command line.

This method was checking if the StatusCheck value was defined via the command line, and if so returning the value it was set to. However since the flag was set to incorrectly default to true, that method would always return true if --status-check= was not set on the command line.

This PR sets the default value of StatusCheck to nil, as this lines up with its usage and type BoolOrUndefined

[codecov]

Codecov Report

Merging #7089 (db285ca) into main (290280e) will decrease coverage by 1.77%.
The diff coverage is 56.96%.

@@            Coverage Diff             @@
##             main    #7089      +/-   ##
==========================================
- Coverage   70.48%   68.71%   -1.78%     
==========================================
  Files         515      558      +43     
  Lines       23150    26116    +2966     
==========================================
+ Hits        16317    17945    +1628     
- Misses       5776     6947    +1171     
- Partials     1057     1224     +167     

Impacted Files	Coverage Δ
cmd/skaffold/app/cmd/deploy.go	52.00% <ø> (-1.85%)	⬇️
cmd/skaffold/app/cmd/dev.go	84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go	36.66% <0.00%> (-4.72%)	⬇️
cmd/skaffold/skaffold.go	0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go	62.50% <14.28%> (-1.14%)	⬇️
cmd/skaffold/app/cmd/lsp.go	28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go	68.85% <40.00%> (-7.62%)	⬇️
cmd/skaffold/app/cmd/lint.go	42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go	48.88% <50.00%> (+0.24%)	⬆️
cmd/skaffold/app/skaffold.go	76.19% <70.00%> (-8.43%)	⬇️
... and 209 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ae7f6...db285ca. Read the comment docs.

[MarlonGamez]

hey @sbe-genomics , thanks for catching this and creating a fix! Would you mind rebasing this PR? the integration test failure is unrelated and we've merged a fix into main

[sberss]

@MarlonGamez done, thanks!

[MarlonGamez]

Merging this change as the integration test failure is unrelated/needs to be fixed on our end

[gsquared94]

This line needs to be reverted. It breaks specifying --status-check without any arguments.