chore: [v1] cherry pick the fix to collect cluster type on v1 branch#7316
Merged
tejal29 merged 2 commits intoGoogleContainerTools:v1from Apr 19, 2022
Merged
chore: [v1] cherry pick the fix to collect cluster type on v1 branch#7316tejal29 merged 2 commits intoGoogleContainerTools:v1from
tejal29 merged 2 commits intoGoogleContainerTools:v1from
Conversation
While investigating on on how many CLI users deploy to GKE, I found out we were not exporting the detected metric.
tejal29
changed the title
tejal29
changed the title
Codecov Report
@@ Coverage Diff @@
## v1 #7316 +/- ##
=====================================
Coverage ? 67.34%
=====================================
Files ? 559
Lines ? 26665
Branches ? 0
=====================================
Hits ? 17957
Misses ? 7423
Partials ? 1285 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created using
git cherry-pick 97f2bdc9b3c1ef7ad1f5dec2e2e169732712f0a0git commit -am chore: fix the hack/schema-changes.sh on main