chore: v1: add --transform to v1 filter command.#7319
Merged
tejal29 merged 1 commit intoGoogleContainerTools:v1from Apr 21, 2022
Merged
chore: v1: add --transform to v1 filter command.#7319tejal29 merged 1 commit intoGoogleContainerTools:v1from
--transform to v1 filter command.#7319tejal29 merged 1 commit intoGoogleContainerTools:v1from
Conversation
tejal29
force-pushed
the
add_transform_flag
branch
from
3724af8 to
931a095
Compare
tejal29
changed the title
--transform to v1 filter command.
Codecov Report
@@ Coverage Diff @@
## v1 #7319 +/- ##
=====================================
Coverage ? 68.50%
=====================================
Files ? 560
Lines ? 26535
Branches ? 0
=====================================
Hits ? 18178
Misses ? 7096
Partials ? 1261 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
tejal29
force-pushed
the
add_transform_flag
branch
from
931a095 to
398d210
Compare
gsquared94
reviewed
Apr 20, 2022
| WithFlags([]*Flag{ | ||
| {Value: &renderFromBuildOutputFile, Name: "build-artifacts", Shorthand: "a", Usage: "File containing build result from a previous 'skaffold build --file-output'"}, | ||
| {Value: &debuggingFilters, Name: "debugging", DefValue: false, Usage: `Apply debug transforms similar to "skaffold debug"`, IsEnum: true}, | ||
| {Value: &transform, Name: "transform", DefValue: false, Usage: `(experimental) Replace images in manifest and set labels`, IsEnum: true}, |
Contributor
There was a problem hiding this comment.
is there a reason for marking this flag experimental vs just hidden?
gsquared94
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #6683 but for V1 branch
For v1 branch
--tranformflag to the filter command. This command will be used inhelmv3.1Deployerto use helm post renderer functionality for performing image replacements.