fix: fetch images by platform tag when using --platform#7393
Merged
gsquared94 merged 3 commits intoGoogleContainerTools:mainfrom May 12, 2022
Merged
fix: fetch images by platform tag when using --platform#7393gsquared94 merged 3 commits intoGoogleContainerTools:mainfrom
--platform#7393gsquared94 merged 3 commits intoGoogleContainerTools:mainfrom
Conversation
tejal29
changed the title
--platform
Codecov Report
@@ Coverage Diff @@
## main #7393 +/- ##
==========================================
- Coverage 70.48% 66.62% -3.86%
==========================================
Files 515 566 +51
Lines 23150 27120 +3970
==========================================
+ Hits 16317 18069 +1752
- Misses 5776 7755 +1979
- Partials 1057 1296 +239
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
gsquared94
approved these changes
May 12, 2022
Contributor
gsquared94
left a comment
gsquared94
left a comment
There was a problem hiding this comment.
LGTM. Thanks for taking care of this @tejal29
gsquared94
pushed a commit
that referenced
this pull request
May 13, 2022
* fix: Do not ignore supplied platform when retagging an image * fix tests * fix lint' Co-authored-by: Bar Perach <barp@google.com>
gsquared94
pushed a commit
that referenced
this pull request
May 13, 2022
* fix: Do not ignore supplied platform when retagging an image * fix tests * fix lint' Co-authored-by: Bar Perach <barp@google.com>
armsnyder
reviewed
Jun 25, 2022
| // Retrieve the digest for that tag. | ||
| // TODO(dgageot): I don't think GCB can push to an insecure registry. | ||
| return docker.RemoteDigest(defaultToTag, b.cfg) | ||
| return docker.RemoteDigest(defaultToTag, b.cfg, util.ConvertToV1Platform(platforms.Platforms[0])) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix fetching digest by platform.
This is carry over of PR #7301 from an external contributor. They opened it against the v1 branch.
Initial commit belongs to #3559 with rebase on main after v2 merge.
Second commit is tests fixed.