Skip to content

chore: add-schema-v2beta29#7436

Merged
tejal29 merged 1 commit intoGoogleContainerTools:v1from
ericzzzzzzz:add-v2beta29-schema
May 24, 2022
Merged

chore: add-schema-v2beta29#7436
tejal29 merged 1 commit intoGoogleContainerTools:v1from
ericzzzzzzz:add-v2beta29-schema

Conversation

@ericzzzzzzz
Copy link
Copy Markdown
Contributor

Fixes: #7342

Description

  • add a new version schema to support adding region configuration in GoogleCloudBuild in a following up pr

Follow-up Work (remove if N/A)

@ericzzzzzzz ericzzzzzzz requested a review from a team as a code owner May 23, 2022 17:10
@ericzzzzzzz ericzzzzzzz requested review from gsquared94 and removed request for a team May 23, 2022 17:10
@ericzzzzzzz ericzzzzzzz changed the title chore:add-schema-v2beta29 chore: add-schema-v2beta29 May 23, 2022
@ericzzzzzzz ericzzzzzzz force-pushed the add-v2beta29-schema branch 2 times, most recently from ad72db7 to e050988 Compare May 23, 2022 18:37
@codecov
Copy link
Copy Markdown

codecov bot commented May 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v1@7d12109). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             v1    #7436   +/-   ##
=====================================
  Coverage      ?   68.10%           
=====================================
  Files         ?      566           
  Lines         ?    26633           
  Branches      ?        0           
=====================================
  Hits          ?    18139           
  Misses        ?     7210           
  Partials      ?     1284           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ericzzzzzzz ericzzzzzzz force-pushed the add-v2beta29-schema branch from e050988 to 361689c Compare May 23, 2022 20:15
Copy link
Copy Markdown
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tejal29 tejal29 merged commit a3e0b76 into GoogleContainerTools:v1 May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants