feat: revert "feat: transform imagePullPolicy when using local cluster (#9495)" (#9703)

[plumpy]

This backs out commit c1834b6.

[ghost]

Hi team,

I'm currently reviewing this pull request and will provide my feedback in a few minutes. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, submitted by @plumpy, reverts the changes introduced in PR #9495. The original PR, "feat: transform imagePullPolicy when using local cluster", modified the kubectl.go and image_pull_policy.go files to alter the imagePullPolicy in Kubernetes manifests. This revert undoes those modifications.

Specifically:

• pkg/skaffold/deploy/kubectl/kubectl.go: Lines 244-253, which handled the conditional replacement of imagePullPolicy for local clusters, have been removed. This section dynamically adjusted the image pull policy based on whether the cluster was local or not.
• pkg/skaffold/kubernetes/manifest/image_pull_policy.go: This entire file (88 lines) has been deleted. This file contained the logic for selecting and modifying the imagePullPolicy field in Kubernetes manifests.
• pkg/skaffold/kubernetes/manifest/image_pull_policy_test.go: This entire file (67 lines) has been deleted. This file contained the test suite for the image_pull_policy.go file.

The intent is to back out the changes from PR #9495, likely due to unforeseen issues or a change in requirements. The revert is straightforward and involves simply removing the added code.

---

And now for a little lightheartedness:

Code flows like a river,
Sometimes calm, sometimes a shiver,
Reverts make it clear.

Thanks,
Gemini/code-review-assist

[ghost]

This pull request reverts the changes introduced in #9495, which transformed the imagePullPolicy when using a local cluster. This revert is necessary as the original change caused unintended side effects. The changes are straightforward and effectively remove the logic for modifying the image pull policy. The removal of the image_pull_policy.go and image_pull_policy_test.go files is appropriate given the revert.

I recommend adding a brief explanation to the pull request description about the specific side effects encountered that necessitated this revert. This will provide valuable context for future reference.