Set __firebaseKey__ for local additions. Fixes #61 #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Resolves repro in jsBin: http://jsbin.com/hayazi/edit?html,console,output Still need to add unit tests. |
Contributor
|
LGTM. Do you want to add tests now or in a different PR? |
Member
Author
|
Just added tests, but in the process I hit an issue I need to review with @cdata: Looks like the previous change to #60 broke primitive array support, since it was in the remote data handling that primitive values were wrapped (which no longer happens). So this fix only works for arrays with object-valued items; the solution for primitive wasn't immediately clear, would be good to discuss. |
Contributor
|
@kevinpschaaf @robdodson I am gonna close this PR since #63 supersedes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.