Does not redraw when selection changes.#93
Does not redraw when selection changes.#93wesalvaro merged 1 commit intoGoogleWebComponents:masterfrom
Conversation
|
R: @ebidel |
| _typeChanged: function() { | ||
| this._chart = this._createChart(); | ||
| this._chart = createChart(this.type, this.$.chartdiv) | ||
| .then(this._setupChart.bind(this)); |
There was a problem hiding this comment.
promises arent avail in ie 11. This will be a breaking change that we'll need to note...and bump the major versionn
There was a problem hiding this comment.
Is this caveat considering the polyfill? This element has been using iron-ajax to load data which makes use of promises (via the polyfill). It may not be native but it should work.
There was a problem hiding this comment.
Right. That should be OK then. You should also really load the polyfill import in this component too. If iron-ajax is ever removed as the implementation, we'll still want it as a dependency. And add it to bower.json.
There was a problem hiding this comment.
It is in the imports but not in Bower. ;)
There was a problem hiding this comment.
Ah yea. Want to add it there for completeness.?
|
LGTM. Just the addition to bower. |
Fixes GoogleWebComponents#92 Is more intelligent about how to handle selection changes and when to redraw the chart.
Does not redraw when selection changes.
2 participants
Fixes #92
Is more intelligent about how to handle selection changes and when to redraw the chart.