Derive states from MainActivity alias enabled

[Copilot]

hideAppIcon defaulted to false regardless of the actual MainActivityAlias component state, causing the setting UI to show "not hidden" even when the alias was already disabled.

Changes

• UiStore.kt: Replace defaultValue = false with a lazy defaultValueProvider lambda that calls PackageManager.getComponentEnabledSetting() on MainActivityAlias — defaults to true only when the component is neither COMPONENT_ENABLED_STATE_ENABLED nor COMPONENT_ENABLED_STATE_DEFAULT. The lookup is deferred until hideAppIcon is first read and the key is absent from preferences, avoiding unnecessary binder calls in non-UI paths (e.g., service start).
• Store.kt: Added a boolean(key, defaultValueProvider: () -> Boolean) overload that invokes the supplier only when the key is not present in storage.
• StoreProvider.kt / Providers.kt: Added contains(key) to the StoreProvider interface and implemented it in SharedPreferenceProvider.

// Before
var hideAppIcon: Boolean by store.boolean(
    key = "hide_app_icon",
    defaultValue = false
)

// After
var hideAppIcon: Boolean by store.boolean(
    key = "hide_app_icon",
    defaultValueProvider = {
        context.packageManager.getComponentEnabledSetting(
            ComponentName(context, context.mainActivityAlias)
        ).let { state ->
            state != PackageManager.COMPONENT_ENABLED_STATE_ENABLED &&
                state != PackageManager.COMPONENT_ENABLED_STATE_DEFAULT
        }
    },
)

COMPONENT_ENABLED_STATE_DEFAULT and COMPONENT_ENABLED_STATE_ENABLED both resolve to false (icon visible), matching the manifest default where the alias is enabled. All other states (including COMPONENT_ENABLED_STATE_DISABLED_USER and COMPONENT_ENABLED_STATE_DISABLED_UNTIL_USED) resolve to true (icon hidden).

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

[Copilot]

Pull request overview

This PR fixes the settings UI showing an incorrect “app icon hidden” state by deriving the hideAppIcon default from the launcher alias component’s enabled state instead of always defaulting to false.

Changes:

• Compute UiStore.hideAppIcon default based on PackageManager.getComponentEnabledSetting() for MainActivityAlias.
• Reuse hideAppIcon in MainApplication.setupShortcuts() to decide whether to clear dynamic shortcuts.
• Replace the old mainActivityAlias top-level value with a Context.mainActivityAlias helper and update imports/usages.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
design/src/main/java/com/github/kr328/clash/design/store/UiStore.kt	Derives hideAppIcon default from launcher alias component state; introduces Context.mainActivityAlias.
app/src/main/java/com/github/kr328/clash/MainApplication.kt	Switches shortcut setup gating to use UiStore.hideAppIcon.
app/src/main/java/com/github/kr328/clash/MainActivity.kt	Removes the old mainActivityAlias top-level property.
app/src/main/java/com/github/kr328/clash/AppSettingsActivity.kt	Imports the new mainActivityAlias helper for component enable/disable.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

This PackageManager.getComponentEnabledSetting(...) call is evaluated eagerly every time UiStore is constructed (because defaultValue is computed before it reaches the delegate). UiStore is created in non-UI paths (e.g., service start), so this adds an extra binder call even when hideAppIcon is never read. Consider deferring this lookup until the hide_app_icon key is actually read/missing (e.g., a specialized property getter, or a delegate that accepts a default-value supplier).

[Goooler]

@copilot apply changes based on this feedback

[Copilot]

Done in eb1245b. Added a boolean(key, defaultValueProvider: () -> Boolean) overload to Store and a contains(key) method to StoreProvider/SharedPreferenceProvider. The defaultValueProvider lambda is only invoked when the key is absent from SharedPreferences, so the PackageManager.getComponentEnabledSetting() call is deferred until hideAppIcon is actually read and only runs when no stored preference exists.

[Goooler]

Reverted.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

defaultValue is computed eagerly when UiStore is constructed, so PackageManager.getComponentEnabledSetting(...) (a binder call) will run even when hideAppIcon is never read (e.g., Context.startClashService() constructs UiStore just to read enableVpn). To avoid this overhead, the component-state lookup needs to be deferred until the hide_app_icon key is actually read and missing (e.g., add a defaultValueProvider/contains(key) mechanism in Store, or move the lookup into a custom getter for hideAppIcon).

[Goooler]

Addressed to MetaCubeX#703.