This repository was archived by the owner on Jul 16, 2024. It is now read-only.
Optimize kts logic #18
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| setupApp(AppModule.App) | ||
|
|
||
| dependencies { | ||
| implementations( | ||
| // projects | ||
| project(LibModule.Login.moduleName), | ||
| project(LibModule.Main.moduleName), | ||
| project(LibModule.Web.moduleName) | ||
| ) | ||
| debugImplementations(Libs.leakCanary) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,32 @@ | ||
| @file:Suppress("SpellCheckingInspection") | ||
|
|
||
| // TODO: Make Module sealed | ||
| interface Module { | ||
| val tag: String | ||
| } | ||
|
Comment on lines
+3
to
+6
Owner
Author
There was a problem hiding this comment. Seems issues in |
||
|
|
||
| enum class LibModule(override val tag: String) : Module { | ||
| //---------------------base-------------------------------// | ||
| Base("base"), | ||
| Common("common"), | ||
|
|
||
| //---------------------biz-------------------------------// | ||
| Login("login"), | ||
| Main("main"), | ||
| Web("web"), | ||
|
|
||
| //---------------------func-------------------------------// | ||
| Adapter("adapter") | ||
| } | ||
|
|
||
| enum class AppModule(override val tag: String, val appName: String, val appId: String) : Module { | ||
| App("app", "Demo", "io.goooler.demoapp"), | ||
| Test("app", "Test", "io.goooler.test") | ||
|
Comment on lines
+22
to
+24
Owner
Author
There was a problem hiding this comment. Separate app modules to new enum classes. |
||
| } | ||
|
|
||
| enum class BuildConfigField(val key: String, val value: Any) { | ||
| VersionCode("VERSION_CODE", appVersionCode), | ||
| VersionName("VERSION_NAME", appVersionName), | ||
| CdnPrefix("CDN_PREFIX", "https://raw.githubusercontent.com/"), | ||
| ApiHost("API_HOST", "https://api.github.com/") | ||
|
Comment on lines
+27
to
+31
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,30 @@ | ||
| setupLib(LibModule.Common) { | ||
| buildFeatures.buildConfig = true | ||
| productFlavors.all { | ||
| buildConfigField(BuildConfigField.VersionCode) | ||
| buildConfigField(BuildConfigField.VersionName) | ||
| buildConfigField(BuildConfigField.CdnPrefix) | ||
| buildConfigField(BuildConfigField.ApiHost) | ||
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| apis( | ||
| // project | ||
| project(LibModule.Base.moduleName), | ||
| project(LibModule.Adapter.moduleName), | ||
| // UI | ||
| Libs.constraintLayout, | ||
| Libs.cardView, | ||
| Libs.material, | ||
| *Libs.smartRefreshLayout, | ||
| Libs.photoView, | ||
| // other | ||
| *Libs.rx, | ||
| Libs.collection, | ||
| Libs.utils | ||
| ) | ||
| implementations(*Libs.coil) | ||
| debugImplementations(Libs.chuckerDebug) | ||
| releaseImplementations(Libs.chuckerRelease) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| setupLib(LibModule.Login) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,4 @@ | ||
| setupLib(LibModule.Main) { | ||
| sourceSets["main"].res.srcDirs( | ||
| "src/main/res/core", | ||
| "src/main/res/other" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,4 @@ | ||
| setupApp(AppModule.Test) | ||
|
|
||
| dependencies { | ||
| implementations( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| setupLib(LibModule.Web) { | ||
| buildFeatures.buildConfig = true | ||
| } | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inject module name now in
setupBase.