Skip to content
This repository was archived by the owner on Jul 16, 2024. It is now read-only.

Enable Junit5 instrumentation test#60

Closed
Goooler wants to merge 11 commits intotrunkfrom
plurals
Closed

Enable Junit5 instrumentation test#60
Goooler wants to merge 11 commits intotrunkfrom
plurals

Conversation

@Goooler
Copy link
Owner

@Goooler Goooler commented Mar 17, 2022 •
edited
Loading

Goooler
Goooler commented Mar 17, 2022
View reviewed changes
common/build.gradle.kts
androidTestImplementation(libs.kotlin.junit5)
androidTestImplementation(libs.androidX.test.runner)
androidTestImplementation(libs.junit5Android.core)
androidTestRuntimeOnly(libs.junit5Android.runner)
Copy link
Owner Author

@Goooler Goooler Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/mannodermaus/android-junit5#instrumentation-test-support

@Goooler Goooler added this to the 1.6.0 milestone Mar 17, 2022
@Goooler Goooler marked this pull request as draft March 18, 2022 10:09
Goooler
Goooler commented Mar 18, 2022
View reviewed changes
Goooler
Goooler commented Mar 18, 2022
View reviewed changes
This was referenced Mar 18, 2022
Closed
Merged
@Goooler Goooler changed the title Add Int.getQuantityString Enable Junit5 instrumentation test Mar 19, 2022
@Goooler
Merge branch 'trunk' into plurals
0299b91 
# Conflicts:
#	common/src/main/kotlin/io/goooler/demoapp/common/util/CommonExtensions.kt
@Goooler Goooler added the enhancement New feature or request label Mar 21, 2022
Goooler
Goooler commented Apr 9, 2022
View reviewed changes
gradle/libs.versions.toml
[plugins]
android-application = { id = "com.android.application", version.ref = "agp" }
android-library = { id = "com.android.library", version.ref = "agp" }
androidJunit5 = "de.mannodermaus.android-junit5:1.8.2.1-SNAPSHOT"
Copy link
Owner Author

@Goooler Goooler Apr 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mannodermaus/android-junit-framework#265 (comment)

@Goooler
Copy link
Owner Author

Goooler commented Apr 9, 2022 

> Task :common:connectedDevDebugAndroidTest

io.goooler.demoapp.common.CommonExtensionsTest > intGetQuantityStringTest[test(AVD) - 10] FAILED 
	org.opentest4j.AssertionFailedError: expected: <null> but was: <1 song found.>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
Tests on test(AVD) - 10 failed: There was 1 failure(s).

@Goooler Goooler added the dependencies Pull requests that update a dependency file label Apr 10, 2022
@Goooler
Copy link
Owner Author

Goooler commented Apr 10, 2022

May consider using #82 instead.

@Goooler Goooler closed this Apr 10, 2022
@Goooler Goooler removed this from the 1.6.0 milestone Apr 10, 2022
@Goooler Goooler deleted the plurals branch April 10, 2022 08:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request instrumentation-tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Goooler