Conversation
8cf17e7 to
f4969c8
Compare
There was a problem hiding this comment.
Pull request overview
This PR advances issue #65 (“Rewrite UI in Compose”) by migrating the Logs screen from XML/DataBinding + RecyclerView to a Compose-based implementation, and introducing a shared Compose scaffold for consistent top app bars.
Changes:
- Replaced
LogsDesign’s XML layout +RecyclerView.Adapterwith a Compose screen usingLazyColumnand a Material3AlertDialog. - Introduced
MihomoScaffoldand refactoredSettingsCommonScreento use it. - Adjusted
Design.composeViewto provide a lazyComposeView, and updatedHelpDesign/LogsDesignaccordingly.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| design/src/main/res/layout/design_logs.xml | Removes the legacy DataBinding-based logs layout. |
| design/src/main/java/com/github/kr328/clash/design/component/SettingsCommonScreen.kt | Switches settings screen wrapper to use MihomoScaffold. |
| design/src/main/java/com/github/kr328/clash/design/component/MihomoScaffold.kt | Adds a reusable scaffold with a standard top app bar + back handling. |
| design/src/main/java/com/github/kr328/clash/design/adapter/LogFileAdapter.kt | Removes the RecyclerView adapter used by the old logs layout. |
| design/src/main/java/com/github/kr328/clash/design/LogsDesign.kt | Rewrites logs UI in Compose and moves delete-all confirmation into the UI layer. |
| design/src/main/java/com/github/kr328/clash/design/HelpDesign.kt | Updates Compose root initialization to match the new composeView behavior. |
| design/src/main/java/com/github/kr328/clash/design/Design.kt | Makes composeView lazy via unsafeLazy for property delegation. |
| app/src/main/java/com/github/kr328/clash/LogsActivity.kt | Simplifies delete-all handling (confirmation now happens in Compose UI). |
| app/src/main/AndroidManifest.xml | Updates the LogsActivity manifest entry (drops label/configChanges). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9061ae0 to
631f40f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #65.