Skip to content

Rewrite LogcatScreen#78

Merged
Goooler merged 10 commits intotrunkfrom
rewrite-logcat-design
Apr 20, 2026
Merged

Rewrite LogcatScreen#78
Goooler merged 10 commits intotrunkfrom
rewrite-logcat-design

Conversation

@Goooler
Copy link
Copy Markdown
Owner

@Goooler Goooler commented Apr 20, 2026

Refs #65.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Rewrites the Logcat UI to Jetpack Compose and removes the legacy XML/RecyclerView implementation (refs #65).

Changes:

  • Replace LogcatDesign UI with a Compose-based LogcatScreen using LazyColumn.
  • Remove legacy logcat layouts and RecyclerView adapter/resources.
  • Update LogcatActivity to the simplified patchMessages(messages) API and adjust manifest entry.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
design/src/main/res/values/dimens.xml Removes logcat-specific padding dimens previously used by the legacy layouts.
design/src/main/res/layout/design_logcat.xml Deletes the old data-binding XML layout for the logcat screen.
design/src/main/res/layout/design_app_crashed.xml Replaces removed dimen references with hard-coded padding values.
design/src/main/res/layout/adapter_log_message.xml Deletes the old RecyclerView row layout for log messages.
design/src/main/java/com/github/kr328/clash/design/adapter/LogMessageAdapter.kt Removes the legacy RecyclerView adapter implementation.
design/src/main/java/com/github/kr328/clash/design/LogcatDesign.kt Introduces Compose LogcatScreen and message rendering; updates patching/scrolling behavior.
app/src/main/java/com/github/kr328/clash/LogcatActivity.kt Updates calls to the new patchMessages(messages) signature.
app/src/main/AndroidManifest.xml Simplifies LogcatActivity manifest entry (drops label/configChanges).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread design/src/main/java/com/github/kr328/clash/design/LogcatDesign.kt
Comment thread design/src/main/res/layout/design_app_crashed.xml
Comment thread app/src/main/AndroidManifest.xml
Comment thread design/src/main/java/com/github/kr328/clash/design/LogcatDesign.kt Outdated
Comment thread design/src/main/java/com/github/kr328/clash/design/LogcatDesign.kt
Goooler and others added 2 commits April 20, 2026 13:13
…n.kt

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI commented Apr 20, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)
  • scans-in.gradle.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread design/src/main/java/com/github/kr328/clash/design/LogcatDesign.kt Outdated
…n.kt

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Goooler Goooler enabled auto-merge (squash) April 20, 2026 05:24
@Goooler Goooler merged commit 8f0519c into trunk Apr 20, 2026
1 check passed
@Goooler Goooler deleted the rewrite-logcat-design branch April 20, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants