Conversation
There was a problem hiding this comment.
Pull request overview
Rewrites the Logcat UI to Jetpack Compose and removes the legacy XML/RecyclerView implementation (refs #65).
Changes:
- Replace
LogcatDesignUI with a Compose-basedLogcatScreenusingLazyColumn. - Remove legacy logcat layouts and RecyclerView adapter/resources.
- Update
LogcatActivityto the simplifiedpatchMessages(messages)API and adjust manifest entry.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| design/src/main/res/values/dimens.xml | Removes logcat-specific padding dimens previously used by the legacy layouts. |
| design/src/main/res/layout/design_logcat.xml | Deletes the old data-binding XML layout for the logcat screen. |
| design/src/main/res/layout/design_app_crashed.xml | Replaces removed dimen references with hard-coded padding values. |
| design/src/main/res/layout/adapter_log_message.xml | Deletes the old RecyclerView row layout for log messages. |
| design/src/main/java/com/github/kr328/clash/design/adapter/LogMessageAdapter.kt | Removes the legacy RecyclerView adapter implementation. |
| design/src/main/java/com/github/kr328/clash/design/LogcatDesign.kt | Introduces Compose LogcatScreen and message rendering; updates patching/scrolling behavior. |
| app/src/main/java/com/github/kr328/clash/LogcatActivity.kt | Updates calls to the new patchMessages(messages) signature. |
| app/src/main/AndroidManifest.xml | Simplifies LogcatActivity manifest entry (drops label/configChanges). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…n.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Goooler/MihomoForAndroid/sessions/5c2e2bd4-181b-4a83-920a-811576e686d2 Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…n.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Refs #65.