Skip to content

Rewrite ApkBrokenDesign#80

Merged
Goooler merged 2 commits intotrunkfrom
rewrite-apk-broken-design
Apr 20, 2026
Merged

Rewrite ApkBrokenDesign#80
Goooler merged 2 commits intotrunkfrom
rewrite-apk-broken-design

Conversation

@Goooler
Copy link
Copy Markdown
Owner

@Goooler Goooler commented Apr 20, 2026

Refs #65.

@Goooler Goooler force-pushed the rewrite-apk-broken-design branch from 73c5d76 to e13037d Compare April 20, 2026 06:08
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the “APK broken” error screen to use the Compose-based settings components, aligning it with the ongoing “Rewrite UI in Compose” effort (refs #65).

Changes:

  • Rewrites ApkBrokenDesign from ViewBinding/preferences DSL to a Compose screen and removes the activity-side request loop.
  • Exposes a shared GitHub URL constant and link-opening helper from HelpDesign for reuse by ApkBrokenDesign.
  • Minor Compose preview cleanup (expression-body previews) and adds SettingsTipsItem overloads to support more text types.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
design/src/main/res/values/strings.xml Removes the unused meta_github_url string resource.
design/src/main/java/com/github/kr328/clash/design/component/SettingsCommonScreen.kt Adds SettingsTipsItem overloads and allows custom tip content composables.
design/src/main/java/com/github/kr328/clash/design/LogsDesign.kt Simplifies preview composable formatting.
design/src/main/java/com/github/kr328/clash/design/HelpDesign.kt Makes CMFA_GITHUB and Context.openLink() internal for reuse.
design/src/main/java/com/github/kr328/clash/design/FilesDesign.kt Simplifies preview composable formatting.
design/src/main/java/com/github/kr328/clash/design/AppCrashedDesign.kt Simplifies preview composable formatting.
design/src/main/java/com/github/kr328/clash/design/ApkBrokenDesign.kt Rewrites the broken-APK UI to Compose and opens the releases link directly.
app/src/main/java/com/github/kr328/clash/ApkBrokenActivity.kt Removes the request-consumption loop since the design now opens links directly.
app/src/main/AndroidManifest.xml Removes uiMode configChanges and label from ApkBrokenActivity.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread design/src/main/java/com/github/kr328/clash/design/ApkBrokenDesign.kt Outdated
Comment thread design/src/main/java/com/github/kr328/clash/design/HelpDesign.kt
…sign.kt

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Goooler Goooler enabled auto-merge (squash) April 20, 2026 06:12
@Goooler Goooler merged commit c6a2390 into trunk Apr 20, 2026
1 check passed
@Goooler Goooler deleted the rewrite-apk-broken-design branch April 20, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants