Conversation
73c5d76 to
e13037d
Compare
There was a problem hiding this comment.
Pull request overview
Refactors the “APK broken” error screen to use the Compose-based settings components, aligning it with the ongoing “Rewrite UI in Compose” effort (refs #65).
Changes:
- Rewrites
ApkBrokenDesignfrom ViewBinding/preferences DSL to a Compose screen and removes the activity-side request loop. - Exposes a shared GitHub URL constant and link-opening helper from
HelpDesignfor reuse byApkBrokenDesign. - Minor Compose preview cleanup (expression-body previews) and adds
SettingsTipsItemoverloads to support more text types.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| design/src/main/res/values/strings.xml | Removes the unused meta_github_url string resource. |
| design/src/main/java/com/github/kr328/clash/design/component/SettingsCommonScreen.kt | Adds SettingsTipsItem overloads and allows custom tip content composables. |
| design/src/main/java/com/github/kr328/clash/design/LogsDesign.kt | Simplifies preview composable formatting. |
| design/src/main/java/com/github/kr328/clash/design/HelpDesign.kt | Makes CMFA_GITHUB and Context.openLink() internal for reuse. |
| design/src/main/java/com/github/kr328/clash/design/FilesDesign.kt | Simplifies preview composable formatting. |
| design/src/main/java/com/github/kr328/clash/design/AppCrashedDesign.kt | Simplifies preview composable formatting. |
| design/src/main/java/com/github/kr328/clash/design/ApkBrokenDesign.kt | Rewrites the broken-APK UI to Compose and opens the releases link directly. |
| app/src/main/java/com/github/kr328/clash/ApkBrokenActivity.kt | Removes the request-consumption loop since the design now opens links directly. |
| app/src/main/AndroidManifest.xml | Removes uiMode configChanges and label from ApkBrokenActivity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…sign.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #65.