Rewrite ProxyDesign by Goooler · Pull Request #83 · Goooler/MihomoForAndroid

Goooler · 2026-04-20T08:28:00Z

Refs #65.

Copilot

Pull request overview

Migrates the Proxy screen UI implementation from the legacy View/XML-based design to Jetpack Compose, in line with the “Rewrite UI in Compose” effort.

Changes:

Replaced ProxyDesign UI with a Compose-based pager + grid layout and a bottom-sheet menu.
Removed the legacy Proxy XML layout and associated custom view/RecyclerView adapter infrastructure.
Refactored Access Control bottom sheet usage (and previews) to use ModalBottomSheet content directly; updated ProxyActivity manifest entry.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
design/src/main/res/layout/design_proxy.xml	Removed the legacy DataBinding-based proxy layout.
design/src/main/java/com/github/kr328/clash/design/component/ProxyView.kt	Removed the legacy custom `View`-based proxy card renderer.
design/src/main/java/com/github/kr328/clash/design/component/ProxyPageFactory.kt	Removed the legacy ViewPager/RecyclerView page factory.
design/src/main/java/com/github/kr328/clash/design/component/ProxyMenu.kt	Removed the legacy `PopupMenu`-based proxy menu implementation.
design/src/main/java/com/github/kr328/clash/design/adapter/ProxyPageAdapter.kt	Removed the legacy paging adapter tying groups to RecyclerViews.
design/src/main/java/com/github/kr328/clash/design/adapter/ProxyAdapter.kt	Removed the legacy per-group proxy list adapter.
design/src/main/java/com/github/kr328/clash/design/ProxyDesign.kt	New Compose-based Proxy screen (pager, grid cards, bottom-sheet menu, URL test action).
design/src/main/java/com/github/kr328/clash/design/AccessControlDesign.kt	Adjusted bottom-sheet composition approach + previews to fit `ColumnScope` content.
app/src/main/AndroidManifest.xml	Updated `ProxyActivity` manifest attributes (removed label/configChanges).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…olDesign.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Goooler · 2026-04-21T04:57:53Z

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/Goooler/MihomoForAndroid/sessions/0803198a-2cdb-4086-979b-3f9cab618f5c Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>

Copilot · 2026-04-21T05:00:14Z

@copilot apply changes based on the comments in this thread

Implemented the requested thread updates in commit d0a52c6: Proxy menu checkbox/radio rows now use toggleable(..., role = Role.Checkbox) and selectable(..., role = Role.RadioButton) for proper accessibility semantics. Screenshot: no visual UI change in this update (semantics/accessibility behavior only).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

dl.google.com
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)
scans-in.gradle.com
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Agent-Logs-Url: https://github.com/Goooler/MihomoForAndroid/sessions/51f03a89-2494-40cd-a017-9c1ffba7fbbb Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>

Copilot · 2026-04-21T05:22:34Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

dl.google.com
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)
scans-in.gradle.com
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-21T05:36:03Z

+  LazyVerticalGrid(
+    columns = GridCells.Fixed(columnsForProxyLine(proxyLine)),
+    state = rememberLazyGridState(),
+    modifier = Modifier.fillMaxSize(),


LazyVerticalGrid uses a fresh rememberLazyGridState() inside each pager page. With HorizontalPager (default beyondViewportPageCount = 0), off-screen pages are typically disposed, so when users switch tabs and come back, the grid scroll position will reset. Consider hoisting a LazyGridState per group/page (e.g., keep a List<LazyGridState> in ProxyPagerContent via remember/rememberSaveable and pass it down, or store it in ProxyGroupUiState) to preserve per-tab scroll state.

Goooler force-pushed the rewrite-proxy-design branch 2 times, most recently from 3b6709e to 3f191ad Compare April 21, 2026 04:41

Rewrite ProxyDesign

509d932

Goooler force-pushed the rewrite-proxy-design branch from 3f191ad to 509d932 Compare April 21, 2026 04:47

Goooler requested a review from Copilot April 21, 2026 04:47

Copilot started reviewing on behalf of Goooler April 21, 2026 04:47 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Goooler and others added 6 commits April 21, 2026 12:53

Update design/src/main/java/com/github/kr328/clash/design/ProxyDesign.kt

fefc367

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update design/src/main/java/com/github/kr328/clash/design/AccessContr…

097ef91

…olDesign.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update design/src/main/java/com/github/kr328/clash/design/ProxyDesign.kt

78c6922

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update design/src/main/java/com/github/kr328/clash/design/ProxyDesign.kt

5e559aa

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix build

da4022d

12.dp for contentPadding

8fa7a5b

Copilot started work on behalf of Goooler April 21, 2026 04:58 View session

Improve Proxy menu accessibility semantics

d0a52c6

Agent-Logs-Url: https://github.com/Goooler/MihomoForAndroid/sessions/0803198a-2cdb-4086-979b-3f9cab618f5c Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>

Copilot finished work on behalf of Goooler April 21, 2026 05:01

Goooler requested a review from Copilot April 21, 2026 05:02

Copilot started reviewing on behalf of Goooler April 21, 2026 05:02 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Apply suggestions from code review

4bdd23e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Goooler requested a review from Copilot April 21, 2026 05:08

Copilot started reviewing on behalf of Goooler April 21, 2026 05:08 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Comment thread design/src/main/java/com/github/kr328/clash/design/ProxyDesign.kt

Comment thread design/src/main/java/com/github/kr328/clash/design/ProxyDesign.kt

Copilot started work on behalf of Goooler April 21, 2026 05:14 View session

Copilot AI and others added 4 commits April 21, 2026 05:16

Optimize Proxy group refresh to visible-item updates

a3ee604

Agent-Logs-Url: https://github.com/Goooler/MihomoForAndroid/sessions/51f03a89-2494-40cd-a017-9c1ffba7fbbb Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>

Cache visible proxy item updates per refresh cycle

7ae0886

Agent-Logs-Url: https://github.com/Goooler/MihomoForAndroid/sessions/51f03a89-2494-40cd-a017-9c1ffba7fbbb Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>

Stabilize Proxy grid item source snapshot

d798b86

Agent-Logs-Url: https://github.com/Goooler/MihomoForAndroid/sessions/51f03a89-2494-40cd-a017-9c1ffba7fbbb Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>

Key visible proxy cache by proxy identity

d1df817

Agent-Logs-Url: https://github.com/Goooler/MihomoForAndroid/sessions/51f03a89-2494-40cd-a017-9c1ffba7fbbb Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>

Copilot AI and others added 3 commits April 21, 2026 05:19

Use effect-driven visible proxy UI state updates

52459f5

Agent-Logs-Url: https://github.com/Goooler/MihomoForAndroid/sessions/51f03a89-2494-40cd-a017-9c1ffba7fbbb Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>

Key remembered proxy item state by refresh version

ef62963

Agent-Logs-Url: https://github.com/Goooler/MihomoForAndroid/sessions/51f03a89-2494-40cd-a017-9c1ffba7fbbb Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>

Avoid unnecessary remember state recreation

229b4ec

Agent-Logs-Url: https://github.com/Goooler/MihomoForAndroid/sessions/51f03a89-2494-40cd-a017-9c1ffba7fbbb Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>

Copilot finished work on behalf of Goooler April 21, 2026 05:22

Goooler requested a review from Copilot April 21, 2026 05:23

Copilot started reviewing on behalf of Goooler April 21, 2026 05:23 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Comment thread design/src/main/java/com/github/kr328/clash/design/ProxyDesign.kt

Comment thread app/src/main/AndroidManifest.xml

Goooler added 2 commits April 21, 2026 13:29

Mark private

b4fea46

Fix first frame

306ad35

Goooler requested a review from Copilot April 21, 2026 05:31

Copilot started reviewing on behalf of Goooler April 21, 2026 05:31 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Goooler merged commit 5537618 into trunk Apr 21, 2026
5 checks passed

Goooler deleted the rewrite-proxy-design branch April 21, 2026 05:37

Conversation

Goooler commented Apr 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Goooler commented Apr 21, 2026

Uh oh!

Copilot AI commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Apr 21, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 21, 2026 •

edited

Loading