Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the Providers screen in the design module from XML/DataBinding + RecyclerView to a Jetpack Compose implementation, aligning with the ongoing “Rewrite UI in Compose” effort (Issue #65).
Changes:
- Replaces
design_providers.xml/adapter_provider.xml+ProviderAdapterwith a Compose-basedProvidersDesignscreen. - Moves “elapsed time” updating from
ProvidersActivity’s ticker to a ComposeLaunchedEffectloop. - Simplifies
ProvidersActivityand updates the manifest entry forProvidersActivity.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| design/src/main/res/layout/design_providers.xml | Removes legacy XML layout for Providers screen (Compose migration). |
| design/src/main/res/layout/adapter_provider.xml | Removes legacy XML row layout used by RecyclerView adapter (Compose migration). |
| design/src/main/java/com/github/kr328/clash/design/adapter/ProviderAdapter.kt | Deletes RecyclerView adapter now replaced by Compose list rendering. |
| design/src/main/java/com/github/kr328/clash/design/ProvidersDesign.kt | Implements Providers UI in Compose (scaffold + lazy list + item row + update actions). |
| app/src/main/java/com/github/kr328/clash/ProvidersActivity.kt | Removes minute ticker logic; relies on Compose-driven elapsed-time updates. |
| app/src/main/AndroidManifest.xml | Removes uiMode config handling from ProvidersActivity entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #65.