Skip to content

Rewrite ProfilesDesign#85

Merged
Goooler merged 2 commits intotrunkfrom
rewrite-providers-design
Apr 20, 2026
Merged

Rewrite ProfilesDesign#85
Goooler merged 2 commits intotrunkfrom
rewrite-providers-design

Conversation

@Goooler
Copy link
Copy Markdown
Owner

@Goooler Goooler commented Apr 20, 2026

Refs #65.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the Providers screen in the design module from XML/DataBinding + RecyclerView to a Jetpack Compose implementation, aligning with the ongoing “Rewrite UI in Compose” effort (Issue #65).

Changes:

  • Replaces design_providers.xml / adapter_provider.xml + ProviderAdapter with a Compose-based ProvidersDesign screen.
  • Moves “elapsed time” updating from ProvidersActivity’s ticker to a Compose LaunchedEffect loop.
  • Simplifies ProvidersActivity and updates the manifest entry for ProvidersActivity.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
design/src/main/res/layout/design_providers.xml Removes legacy XML layout for Providers screen (Compose migration).
design/src/main/res/layout/adapter_provider.xml Removes legacy XML row layout used by RecyclerView adapter (Compose migration).
design/src/main/java/com/github/kr328/clash/design/adapter/ProviderAdapter.kt Deletes RecyclerView adapter now replaced by Compose list rendering.
design/src/main/java/com/github/kr328/clash/design/ProvidersDesign.kt Implements Providers UI in Compose (scaffold + lazy list + item row + update actions).
app/src/main/java/com/github/kr328/clash/ProvidersActivity.kt Removes minute ticker logic; relies on Compose-driven elapsed-time updates.
app/src/main/AndroidManifest.xml Removes uiMode config handling from ProvidersActivity entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread design/src/main/java/com/github/kr328/clash/design/ProvidersDesign.kt Outdated
Comment thread app/src/main/AndroidManifest.xml
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Goooler Goooler enabled auto-merge (squash) April 20, 2026 09:14
@Goooler Goooler merged commit 27792ae into trunk Apr 20, 2026
1 check passed
@Goooler Goooler deleted the rewrite-providers-design branch April 20, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants