Skip to content

Pin clash-foss submodule to mihomo v1.19.24 tag#92

Merged
Goooler merged 7 commits intotrunkfrom
copilot/update-git-submodule-to-tag
Apr 21, 2026
Merged

Pin clash-foss submodule to mihomo v1.19.24 tag#92
Goooler merged 7 commits intotrunkfrom
copilot/update-git-submodule-to-tag

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 21, 2026

  • Inspect latest CI failure logs for the new comment about CMake
  • Apply the minimal CMakeLists update required by the submodule/tag pin
  • Run targeted validation for the affected build path
  • Run final validation and reply to the new PR comment

@Goooler Goooler marked this pull request as ready for review April 21, 2026 01:33
Agent-Logs-Url: https://github.com/Goooler/MihomoForAndroid/sessions/84978c49-7732-48db-917a-1deeb46bbdc0

Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented Apr 21, 2026

@copilot Fix

...

Fixed in 3b25b98. I initialized the submodule and ran go mod tidy in both core/src/foss/golang and core/src/main/golang, which updated both go.mod/go.sum pairs to match the pinned v1.19.24 submodule state.

Copy link
Copy Markdown
Author

Copilot AI commented Apr 21, 2026

@copilot Seems need to update core/src/main/cpp/CMakeLists.txt as well, see https://productionresultssa7.blob.core.windows.net/actions-results/93f1d540-25f4-4afe-a700-25189fe42ec6/workflow-job-run-d...

Fixed in 232872e. I updated core/src/main/cpp/CMakeLists.txt to write version.h to ${CMAKE_CURRENT_BINARY_DIR} (instead of the source dir) and added that binary dir to include paths.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)
  • scans-in.gradle.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@Goooler Goooler merged commit 782a9cd into trunk Apr 21, 2026
1 check passed
@Goooler Goooler deleted the copilot/update-git-submodule-to-tag branch April 21, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants