Unwrap AppSettingsDesign#130
Merged
Merged
Conversation
Goooler
force-pushed
the
unwrap-app-settings
branch
from
dd2d709 to
0bdfe71
Compare
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refactors the App Settings UI by removing the old Design wrapper and moving state/side-effects into a dedicated AppSettingsViewModel (refs #119).
Changes:
- Added
AppSettingsViewModelto own settings state and apply changes to stores/PackageManager. - Reworked
AppSettingsScreeninto a ViewModel-driven Compose screen (AppSettingsContent+collectAsStateWithLifecycle). - Simplified
AppSettingsActivityto a ComposesetContenthost.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/src/main/kotlin/com/github/kr328/clash/settings/vm/AppSettingsViewModel.kt | New ViewModel to manage settings state and apply platform side-effects (auto-restart, hide icon). |
| app/src/main/kotlin/com/github/kr328/clash/settings/ui/AppSettingsScreen.kt | Replaces AppSettingsDesign with a ViewModel-backed Compose screen and stateless content composable. |
| app/src/main/kotlin/com/github/kr328/clash/settings/AppSettingsActivity.kt | Drops DesignActivity loop/event handling; hosts Compose screen directly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Goooler
force-pushed
the
unwrap-app-settings
branch
from
0bdfe71 to
a14944f
Compare
Goooler
force-pushed
the
unwrap-app-settings
branch
from
a14944f to
5fa996e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #119.