Unwrap MetaFeatureSettingsScreen

[Goooler]

Refs #119.

[Goooler]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

Applied both remaining unresolved comments in 534b402:

1. importGeoFile() exception handling — wrapped the entire coroutine body in try/catch, so any exception from content resolver queries, stream opens, or file I/O sets importResult to Failed instead of leaving it stale.
2. updateState() atomicity — replaced uiState.value = transform(uiState.value) with uiState.update(transform) (imported kotlinx.coroutines.flow.update) to make the read-modify-write atomic, matching the pattern used in NetworkSettingsViewModel.

[Copilot]

Pull request overview

This PR continues the “Design → @Composable + ViewModel” refactor for Meta feature settings (refs #119), moving state/persistence and geo-file import logic into a dedicated ViewModel while converting the UI into a standalone Compose screen.

Changes:

• Introduces MetaFeatureSettingsViewModel to own ConfigurationOverride UI state, persistence, and geo database import behavior.
• Reworks MetaFeatureSettingsScreen into a pure Compose screen that binds to the ViewModel and delegates state updates through an actions interface.
• Adds new preference-item overloads to support stateless/value-driven preference wiring (instead of MutableState write-through).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
app/src/main/kotlin/com/github/kr328/clash/ui/component/SettingsPreference.kt	Adds value/onValueChange overloads for list/edit-text preference items to better support ViewModel-backed state.
app/src/main/kotlin/com/github/kr328/clash/settings/vm/MetaFeatureSettingsViewModel.kt	New ViewModel for loading/patching overrides and importing geo database files.
app/src/main/kotlin/com/github/kr328/clash/settings/ui/MetaFeatureSettingsScreen.kt	Converts the previous design-based screen into a ViewModel-backed Compose screen and introduces an actions interface.
app/src/main/kotlin/com/github/kr328/clash/settings/MetaFeatureSettingsActivity.kt	Migrates the activity from DesignActivity to BaseActivity + setContent and wires in the ViewModel.

Comments suppressed due to low confidence (2)

app/src/main/kotlin/com/github/kr328/clash/settings/ui/MetaFeatureSettingsScreen.kt:79

• importResult is kept as the latest StateFlow value, and LaunchedEffect(importResult) will re-run when the Composable re-enters composition (e.g., configuration change) with importResult == Success/UnsupportedFormat/Failed, causing the toast/dialog to show again without a new import. Consider modeling import results as one-shot events (SharedFlow/Channel) or clearing/resetting the result after it has been handled (e.g., set back to NotStart once the toast/dialog is triggered).
  app/src/main/kotlin/com/github/kr328/clash/settings/ui/MetaFeatureSettingsScreen.kt:71
• Using stringResource(R.string.geofile_imported) and then calling .format(...) bypasses Android's resource formatting helpers and relies on String.format behavior. Prefer context.getString(R.string.geofile_imported, result.displayName) (or stringResource(R.string.geofile_imported, ...) in composition) so formatting is handled consistently with Android string resources and translations.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.