Honor dark mode from settings#175
Merged
Merged
Conversation
Goooler
force-pushed
the
honor-color-themes
branch
from
586e282 to
b737b20
Compare
There was a problem hiding this comment.
Pull request overview
Updates the app theming pipeline so UI dark mode can be driven by the user’s in-app setting (Force Dark / Force Light / Auto) rather than only the system theme, and aligns system bar appearance accordingly.
Changes:
- Read
UiStore.darkModeinsideMihomoThemeto choose dark/light color tokens. - Recreate the Activity after dark mode setting changes so the theme picks up the new preference immediately.
- Configure
enableEdgeToEdge()system bar styling based on the selected dark mode setting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/kotlin/com/github/kr328/clash/ui/theme/Theme.kt | Derives darkTheme from UiStore.darkMode (with Auto falling back to system). |
| app/src/main/kotlin/com/github/kr328/clash/settings/ui/AppSettingsScreen.kt | Recreates the current Activity after updating dark mode. |
| app/src/main/kotlin/com/github/kr328/clash/MainActivity.kt | Sets edge-to-edge system bar style according to the configured dark mode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Goooler
force-pushed
the
honor-color-themes
branch
from
b737b20 to
b0c4790
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.