Conversation
Closed
There was a problem hiding this comment.
Pull request overview
This PR changes when dynamic app shortcuts are created so they’re only set up when MainActivity is launched, avoiding shortcut work tied to the launcher alias being enabled/disabled.
Changes:
- Remove shortcut setup from
MainApplicationstartup. - Add shortcut setup to
MainActivity.onCreate(). - Stop removing all dynamic shortcuts when toggling “Hide app icon”.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ui/settings/src/main/kotlin/com/github/kr328/clash/settings/vm/AppSettingsViewModel.kt | Removes the “hide icon” path that cleared dynamic shortcuts. |
| app/src/main/kotlin/com/github/kr328/clash/app/MainApplication.kt | Removes app-start shortcut initialization (but leaves an unused uiStore member/imports). |
| app/src/main/kotlin/com/github/kr328/clash/app/MainActivity.kt | Adds setupShortcuts() and initializes dynamic shortcuts during activity creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
We don't have to remove them when the MainActivityAlias is disabled.
Goooler
force-pushed
the
dont-remove-shortcuts
branch
from
2791f00 to
40cfeb2
Compare
Copilot AI
added a commit
that referenced
this pull request
May 9, 2026
Agent-Logs-Url: https://github.com/Goooler/Tabby/sessions/62ab7036-bf7b-41ef-a64f-e748885cdf40 Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't have to remove them when the MainActivityAlias is disabled.