Set up Compose infra#73
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Sets up initial Jetpack Compose infrastructure for the design module as part of the ongoing UI rewrite (Refs #65).
Changes:
- Added Compose + lifecycle dependencies and Kotlin Compose Gradle plugin to the version catalog.
- Wired the Kotlin Compose plugin into the root project and enabled it for the
designmodule. - Introduced initial Compose Material3 theme primitives (colors, typography, dimens, preview annotation) in
design.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
gradle/libs.versions.toml |
Adds Compose + lifecycle artifacts and the Kotlin Compose plugin alias. |
build.gradle.kts |
Registers the Kotlin Compose plugin for subprojects (apply false). |
design/build.gradle.kts |
Applies Kotlin Compose plugin and adds Compose dependencies to design. |
design/src/main/java/com/github/kr328/clash/design/ui/theme/Color.kt |
Defines Compose color tokens for light/dark themes. |
design/src/main/java/com/github/kr328/clash/design/ui/theme/Type.kt |
Defines Material3 Typography and custom text-style tokens. |
design/src/main/java/com/github/kr328/clash/design/ui/theme/Theme.kt |
Defines Material3 color schemes, dimens, and theme wrapper + preview annotation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This reverts commit a30253a.
…eme.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…eme.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #65.