Rewrite FilesDesign#77
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR rewrites the Files screen UI from RecyclerView/DataBinding XML to Jetpack Compose as part of the broader Compose migration (refs #65).
Changes:
- Replaced
FilesDesign’s XML/DataBinding +RecyclerView.Adapterimplementation with a Compose-basedFilesScreen(including bottom-sheet actions). - Removed the now-unused Files-related layout XMLs and
FileAdapter. - Updated theme color scheme container surface colors and adjusted activity wiring/manifest entry for
FilesActivity.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| design/src/main/res/layout/dialog_files_menu.xml | Removed obsolete DataBinding bottom-sheet menu layout (replaced by Compose ModalBottomSheet). |
| design/src/main/res/layout/design_files.xml | Removed obsolete DataBinding Files screen layout (replaced by Compose scaffold + list). |
| design/src/main/res/layout/adapter_file.xml | Removed obsolete DataBinding row layout (replaced by Compose FileItem). |
| design/src/main/java/com/github/kr328/clash/design/ui/theme/Theme.kt | Added Material3 surfaceContainer* colors to the app color schemes. |
| design/src/main/java/com/github/kr328/clash/design/adapter/FileAdapter.kt | Removed obsolete RecyclerView adapter (list is now LazyColumn). |
| design/src/main/java/com/github/kr328/clash/design/FilesDesign.kt | New Compose implementation of Files UI, including bottom-sheet actions and elapsed-time display. |
| app/src/main/java/com/github/kr328/clash/FilesActivity.kt | Updated configurationEditable wiring to the new updateConfigurationEditable(...) API. |
| app/src/main/AndroidManifest.xml | Updated FilesActivity manifest entry (label/configChanges removed). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #65.