Rewrite ProfilesDesign#84
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR continues the Compose UI migration (refs #65) by rewriting the Profiles screen implementation to Compose and removing the legacy XML/DataBinding + RecyclerView-based UI.
Changes:
- Replaced
ProfilesDesignXML/RecyclerView implementation with a Compose-based screen including list rendering and a bottom-sheet menu. - Removed the old profiles layouts and adapter that are no longer used.
- Simplified dialogs support by removing the custom
AppBottomSheetDialogimplementation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| design/src/main/res/layout/dialog_profiles_menu.xml | Removed legacy DataBinding bottom-sheet menu layout. |
| design/src/main/res/layout/design_profiles.xml | Removed legacy DataBinding layout for the Profiles screen. |
| design/src/main/java/com/github/kr328/clash/design/dialog/Dialogs.kt | Removed AppBottomSheetDialog implementation, leaving fullscreen dialog support. |
| design/src/main/java/com/github/kr328/clash/design/adapter/ProfileAdapter.kt | Removed old RecyclerView adapter for profiles. |
| design/src/main/java/com/github/kr328/clash/design/ProfilesDesign.kt | New Compose implementation for profiles list UI and actions. |
| app/src/main/AndroidManifest.xml | Updated ProfilesActivity manifest entry (attributes removed). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #65.