Rewrite SettingsDesign#86
Merged
Merged
Conversation
Goooler
force-pushed
the
rewrite-settings-design
branch
from
b9c418a to
703908e
Compare
There was a problem hiding this comment.
Pull request overview
This PR rewrites the Settings landing screen in the design module from an XML/DataBinding implementation to a Jetpack Compose implementation, aligning with the broader “Rewrite UI in Compose” effort (Issue #65).
Changes:
- Removed the legacy
design_settings.xmlDataBinding layout for settings. - Reimplemented
SettingsDesignusing Compose (SettingsCommonScreen+ a custom entry row). - Simplified the
SettingsActivitymanifest entry (but also removeduiModehandling and the activity label).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| design/src/main/res/layout/design_settings.xml | Deletes the old XML/DataBinding settings layout. |
| design/src/main/java/com/github/kr328/clash/design/SettingsDesign.kt | Introduces the new Compose-based settings screen and entry items. |
| app/src/main/AndroidManifest.xml | Updates SettingsActivity declaration (currently drops uiMode configChanges and label). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #65.