Rewrite MainDesign#93
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Rewrites the app’s main screen UI to Jetpack Compose as part of the “Rewrite UI in Compose” effort (Refs #65).
Changes:
- Removed data-binding XML layouts for the main screen and about dialog.
- Implemented
MainDesignUI in Compose, including an in-screen AboutAlertDialog. - Adjusted
MainActivitymanifest attributes related touiModehandling and labeling.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| design/src/main/res/layout/design_main.xml | Removed legacy data-binding main screen layout (replaced by Compose). |
| design/src/main/res/layout/design_about.xml | Removed legacy data-binding about dialog layout (replaced by Compose). |
| design/src/main/java/com/github/kr328/clash/design/MainDesign.kt | New Compose implementation of the main screen, action cards/labels, and About dialog. |
| app/src/main/AndroidManifest.xml | Updated MainActivity manifest attributes (removed uiMode configChanges + label). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #65.