fix: Accept major.minor version in package-for-homebrew.sh#11
Merged
GordonBeeming merged 2 commits intomainfrom Apr 2, 2026
Merged
fix: Accept major.minor version in package-for-homebrew.sh#11GordonBeeming merged 2 commits intomainfrom
GordonBeeming merged 2 commits intomainfrom
Conversation
Version validation rejected "0.3" — now accepts both major.minor and major.minor.patch formats. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: GitButler <gitbutler@gitbutler.com>
There was a problem hiding this comment.
Pull request overview
Updates the Homebrew packaging helper to accept release tags that use a 2-part version (major.minor) in addition to full 3-part semver, aligning the script with tags like v0.3 used in the release pipeline.
Changes:
- Relax version validation in
package-for-homebrew.shto allowmajor.minorandmajor.minor.patch. - Update the validation error message to reflect the newly accepted version formats.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
We don't use prereleases — keep regex and error message consistent. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: GitButler <gitbutler@gitbutler.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package-for-homebrew.shrejected0.3(required 3-part semver)major.minorandmajor.minor.patchformatsTest plan
v0.3