feat: Make all windows float above other apps#15
Merged
GordonBeeming merged 2 commits intomainfrom Apr 3, 2026
Merged
Conversation
Add FloatingWindow ViewModifier that sets NSWindow.level to .floating on appear. Applied to all 5 utility windows (Settings, About, Duration Picker, Time Picker, Schedules) so they stay visible when focus moves to another app — important for a menu bar-only utility. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: GitButler <gitbutler@gitbutler.com>
There was a problem hiding this comment.
Pull request overview
Adds always-on-top behavior to Insomnia’s utility windows to better match expected UX for an LSUIElement menu bar app (windows remain visible when switching to other apps).
Changes:
- Introduces a
FloatingWindowViewModifier+View.floatingWindow()convenience API. - Applies
.floatingWindow()to all five auxiliaryWindowscenes (Settings, About, Duration Picker, Time Picker, Schedules).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Sources/Insomnia/InsomniaApp.swift | Applies the new floating modifier to each auxiliary window’s root view. |
| Sources/Insomnia/FloatingWindowModifier.swift | Implements the floating-window behavior via an onAppear hook and window level change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replace window iteration + timing delay with NSViewRepresentable that reads the specific hosting NSView's .window property. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: GitButler <gitbutler@gitbutler.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FloatingWindowViewModifier that setsNSWindow.level = .floatingon appearTest plan
🤖 Generated with Claude Code