Add support for custom task location or command#63
Merged
robgolding merged 4 commits intodevelopfrom May 13, 2019
Merged
Conversation
robgolding
force-pushed
the
custom-task-command-location
branch
from
3df0653 to
7e5407b
Compare
robgolding
force-pushed
the
custom-task-command-location
branch
from
7e5407b to
ee7b486
Compare
|
@robgolding is this PR done? |
Collaborator
Author
|
The tests have failed here but only because |
Should be more compatible with Windows platforms.
Collaborator
Author
|
@xarthurx OK, I switched to using |
|
@robgolding This works fine! :) |
`wsl` doesn't exist on Travis CI!
Collaborator
Author
|
Great, thanks @xarthurx. In that case since CI is now passing I'll get this merged and release a new version. Thanks again for the help with this! |
jspricke
added a commit
to jspricke/tasklib
that referenced
this pull request
Jan 15, 2021
The test_custom_command was introduced in GothenburgBitFactory#63 with the TASK_VERSION for Travis. As TASK_VERSION is not part of a default environment, the test would still try to run `wsl` on other systems and fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @xarthurx for proposing WSL support in #62. This commit adds support in a different way, by allowing the "task" command to be customised (to
wsl task, for example).