Skip to content

chore: populate Foundations pages #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mxsoco wants to merge 320 commits into from
Closed

chore: populate Foundations pages #252

mxsoco wants to merge 320 commits into from

Conversation

@mxsoco
Copy link
Collaborator

@mxsoco mxsoco commented Oct 10, 2024 •
edited
Loading

Addition of Foundations pages and content into the DS website.

@netlify
Copy link

netlify bot commented Oct 10, 2024 •
edited
Loading

✅ Deploy Preview for abgov-ui-component-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0d68c06
🔍 Latest deploy log https://app.netlify.com/projects/abgov-ui-component-docs/deploys/68260dc80657d10008521bce
😎 Deploy Preview https://deploy-preview-252--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 35
Accessibility: 93
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@chrisolsen chrisolsen marked this pull request as draft October 15, 2024 15:32
@mxsoco mxsoco changed the title chore: populate Accessibility page chore: populate Foundations pages Oct 15, 2024
@lizhuomeng71
Copy link
Collaborator

lizhuomeng71 commented Oct 18, 2024

need a space before "You can use plugins..."

image

@mxsoco
Copy link
Collaborator Author

mxsoco commented Oct 21, 2024

@lizhuomeng71
Made change, but cannot confirm on test page as my changes have not been automatically checked. Still says "This pull request is still a work in progress".

@chrisolsen
Copy link
Collaborator

chrisolsen commented Oct 21, 2024

@mxsoco Since it was your first PR netlify required my approval. It should be available now.

@mxsoco
Copy link
Collaborator Author

mxsoco commented Oct 21, 2024

@chrisolsen Oh I see. Has that always been the case? Up until today, I was able to get a quick check within a few seconds and take a look at my issues.

@chrisolsen
Copy link
Collaborator

chrisolsen commented Oct 21, 2024

@mxsoco There is something that is being flagged in your PR
image

chrisolsen
chrisolsen reviewed Oct 21, 2024
View reviewed changes
src/routes/foundations/Typography.tsx Outdated

<h2>Text styles</h2>
<GoABlock mt="xl" mb="xl">
<div style={{ font: getCssVarValue(`--$goa-typography-heading-xl`) }}>XLarge heading - Perspiciatis unde omnis iste natus error sit.</div>
Copy link
Collaborator

@chrisolsen chrisolsen Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the $

Copy link
Collaborator Author

@mxsoco mxsoco Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed them.

Copy link
Collaborator Author

@mxsoco mxsoco Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what sparked that flagged message you mentioned @chrisolsen?

Copy link
Collaborator

@chrisolsen chrisolsen Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future, the use of the getCssVarValue is not needed. Just using font: "var(--goa-typo...)" should work.

@mxsoco
Copy link
Collaborator Author

mxsoco commented Oct 22, 2024

@chrisolsen please review when you have time. Our team would like to look over the changes later this week.

@chrisolsen
Copy link
Collaborator

chrisolsen commented Oct 22, 2024 •
edited
Loading

Is this running on your local machine?
I am seeing the following errors in the Netflify logs

3:18:02 PM: src/routes/foundations/Iconography.tsx(28,19): error TS1005: '...' expected.
3:18:02 PM: src/routes/foundations/Iconography.tsx(37,19): error TS1005: '...' expected.
3:18:02 PM: src/routes/foundations/Iconography.tsx(46,19): error TS1005: '...' expected.
3:18:02 PM: src/routes/foundations/Iconography.tsx(55,19): error TS1005: '...' expected.
3:18:02 PM: src/routes/foundations/Iconography.tsx(64,19): error TS1005: '...' expected.
3:18:02 PM: src/routes/foundations/Typography.tsx(212,11): error TS1005: '>' expected.

@mxsoco
Copy link
Collaborator Author

mxsoco commented Oct 22, 2024

@chrisolsen I adjusted the lines in the iconography and typography pages

@chrisolsen
Copy link
Collaborator

chrisolsen commented Oct 22, 2024

Are you running the code on your side when making the changes?

@mxsoco
Copy link
Collaborator Author

mxsoco commented Oct 22, 2024 •
edited
Loading

@chrisolsen I am not. I've been making the content changes through GitHub. Before yesterday, was able to get checks done quickly and get a preview.

@chrisolsen
Copy link
Collaborator

chrisolsen commented Oct 23, 2024

@mxsoco Maybe we should get things setup on your side. It will speed up the pace to allow you to see your changes and will prevent any unexpected hold ups. @ArakTaiRoth can help you out with this.

@mxsoco
Copy link
Collaborator Author

mxsoco commented Oct 23, 2024

@chrisolsen was able to setup a local environment. I'll add the updates once I've confirmed them locally.

twjeffery and others added 21 commits May 7, 2025 15:02
@twjeffery
update from review
4777287
@bdfranck
feat(#2122): add notification outage example
42ffef1
@twjeffery
update from review
b7025ef
@bdfranck
Merge pull request #361 from GovAlta/benjifranck/feat-2122
2cd77ba 
feat(#2122): add notification outage example
@twjeffery
Merge pull request #360 from GovAlta/thomasjeffery/feat-2072
e0f33fd 
#2072 home page update
@twjeffery
Merge pull request #351 from GovAlta/sandbox-note
51976c0 
feat: style of sandbox note
@bdfranck
feat(#2136): add textarea example for long question
e36d1ac
@vanessatran-ddi
feat(#2629): add lts policy page
da56cdc
@twjeffery
Merge pull request #366 from GovAlta/vanessa/2629
e55a388 
feat(#2629): add lts policy page
@twjeffery
Merge pull request #363 from GovAlta/benjifranck/feat-2136
f8827e9 
feat(#2136): add textarea example for long question
@mxsoco
Merge branch 'patch-2' into alpha
6653b09
@mxsoco
Merge pull request #2 from mxsoco/alpha
66b1a1b 
Merge alpha into patch-2
@mxsoco
Revert "Merge alpha into patch-2"
5418d81
@mxsoco
Merge pull request #3 from mxsoco/revert-2-alpha
9c1a6dd 
Revert "Merge alpha into patch-2"
@mxsoco
Revert "Revert "Merge alpha into patch-2""
395ac4b
@mxsoco
Merge pull request #4 from mxsoco/revert-3-revert-2-alpha
30a67c7 
Revert "Revert "Merge alpha into patch-2""
@mxsoco
chore: Update components to Goab on all Foundations pages, plus some …
2ad4a05 
…edits.
@mxsoco
chore: Removed Pattern Pages imports from App.tsx
8cd0864
@mxsoco
chore: Updated circle.png
276520f
@mxsoco
chore: Adjustments to logo.tsx
b9852bd
@mxsoco
chore: Content change in logo.tsx
0d68c06
@mxsoco
Copy link
Collaborator Author

mxsoco commented May 15, 2025

@Spark450 @ArakTaiRoth Foundations pages are good to get published. Let me know if there needs to be any adjustments.

@mxsoco mxsoco closed this by deleting the head repository May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisolsen chrisolsen chrisolsen left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.