Skip to content

Conversation

@mxsoco
Copy link
Collaborator

@mxsoco mxsoco commented Dec 5, 2024

This PR stems off of the issue: GovAlta/ui-components#2137

NOTE:

For the phone number example, I replicated the code snippets for the "dollar amount or costs" example including the angular code for the leading content.

image

@netlify
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for abgov-ui-component-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dcef96c
🔍 Latest deploy log https://app.netlify.com/sites/abgov-ui-component-docs/deploys/675777efb5a12800086aa290
😎 Deploy Preview https://deploy-preview-276--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 0
Accessibility: 100
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@mxsoco
Copy link
Collaborator Author

mxsoco commented Dec 5, 2024

@ArakTaiRoth @Spark450 Input ready for review.

@Spark450 Spark450 linked an issue Dec 5, 2024 that may be closed by this pull request
@mxsoco mxsoco self-assigned this Dec 6, 2024
@mxsoco mxsoco added the documentation Improvements or additions to documentation label Dec 6, 2024
@ArakTaiRoth ArakTaiRoth marked this pull request as draft December 9, 2024 22:29
@ArakTaiRoth
Copy link
Collaborator

A couple of issues:

  • For "Ask a user for bank details" Angular Event Based, you're missing the code for the change event.
  • For "Ask a user for bank details" Angular Reactive Forms, you're missing the code for the FormControl's
  • For "Ask a user for bank details" React, you're missing the onChange function referenced in all the input's

@mxsoco
Copy link
Collaborator Author

mxsoco commented Dec 9, 2024

@ArakTaiRoth Adjusted the "...bank details" example. Let me know if there's anything else I should adjust.

@mxsoco mxsoco closed this by deleting the head repository May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants